https://codereview.chromium.org/734163002/diff/20001/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/734163002/diff/20001/src/debug.cc#newcode1203
src/debug.cc:1203: if (function->IsFromNativeScript()) return;
On 2014/11/18 18:51:08, arv wrote:
Maybe this should have been a DCHECK instead. I think all the callers
already
try to handle this.
Nope, only two places out of 7-8 in this file. One check I removed at
line 1255, also should remove at line 1229 (which is also not correct
before calling FloodWithOneShotGeneric)
https://codereview.chromium.org/734163002/diff/20001/test/mjsunit/es6/debug-stepin-promises.js
File test/mjsunit/es6/debug-stepin-promises.js (right):
https://codereview.chromium.org/734163002/diff/20001/test/mjsunit/es6/debug-stepin-promises.js#newcode51
test/mjsunit/es6/debug-stepin-promises.js:51: {
On 2014/11/18 18:51:08, arv wrote:
{ on previous line
Addressed in https://codereview.chromium.org/739523002/
https://codereview.chromium.org/734163002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
