LGTM
https://codereview.chromium.org/734163002/diff/20001/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/734163002/diff/20001/src/debug.cc#newcode1203
src/debug.cc:1203: if (function->IsFromNativeScript()) return;
Maybe this should have been a DCHECK instead. I think all the callers
already try to handle this.
https://codereview.chromium.org/734163002/diff/20001/test/mjsunit/es6/debug-stepin-promises.js
File test/mjsunit/es6/debug-stepin-promises.js (right):
https://codereview.chromium.org/734163002/diff/20001/test/mjsunit/es6/debug-stepin-promises.js#newcode9
test/mjsunit/es6/debug-stepin-promises.js:9: var break_count = 0;
no underscores in js
https://codereview.chromium.org/734163002/diff/20001/test/mjsunit/es6/debug-stepin-promises.js#newcode45
test/mjsunit/es6/debug-stepin-promises.js:45: .then(undefined, promise3)
or
.catch(promise3)
https://codereview.chromium.org/734163002/diff/20001/test/mjsunit/es6/debug-stepin-promises.js#newcode51
test/mjsunit/es6/debug-stepin-promises.js:51: {
{ on previous line
https://codereview.chromium.org/734163002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
