There, hopefully that helps a bit
https://codereview.chromium.org/745233002/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/745233002/diff/1/src/parser.cc#newcode5339
src/parser.cc:5339: unibrow::Utf8Decoder<256> decoder(raw_chars.get(),
to_index);
On 2014/11/25 13:16:21, Dmitry Lomov (chromium) wrote:
Use cached decoder from isoalte()->unicode_cache()->utf8_decoder()
See:
https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/factory.cc&rcl=1416856956&l=240
Should this be cached outside of the loop? But, done and done!
https://codereview.chromium.org/745233002/diff/1/test/mjsunit/harmony/templates.js
File test/mjsunit/harmony/templates.js (right):
https://codereview.chromium.org/745233002/diff/1/test/mjsunit/harmony/templates.js#newcode404
test/mjsunit/harmony/templates.js:404: assertEquals("안녕",
callSites[1].raw[0]);
On 2014/11/25 14:45:00, mathias wrote:
May want to test UTF-8 encoded symbols that take up 3 or 4 bytes as
well.
Example string that contains all of these (from
https://mathiasbynens.be/notes/javascript-unicode#poo-test):
"Iñtërnâtiônàlizætiøn☃💩"
It's not necessarily guaranteed that there is any decoding from utf8
involved --- but I guess it doesn't hurt to add a more thorough unicode
test case. Done and done!
https://codereview.chromium.org/745233002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
