Some post-commit comments:
https://codereview.chromium.org/745233002/diff/40001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/745233002/diff/40001/src/parser.cc#newcode5341
src/parser.cc:5341: decoder->Reset(raw_chars.get(), to_index);
Since we're now doing parsing on a background thread in some use cases,
Parser should remain independent of the Isolate. It gets passed a
ParseInfo which contains the UnicodeCache to use, you can use it here
(via Scanner I guess).
There are guards in place to make sure the background parsing cases
don't mess with the heap, but sadly there are no guards to ensure we
don't access the Isolate in non-thread-safe ways. :/
https://codereview.chromium.org/745233002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
