lgtm, with some comments. Thanks for doing this Yang!
https://codereview.chromium.org/759823006/diff/40001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/759823006/diff/40001/src/heap/heap.cc#newcode1833
src/heap/heap.cc:1833: return EnsureDoubleAligned(this, object, size);
Could you add an ASSERT(object->NeedsToEnsureDoubleAlignment()) in
EnsureDoubleAligned to ensure that the list in
NeedsToEnsureDoubleAlignment keeps in sync with objects which call
EnsureDoubleAligned during allocation.
https://codereview.chromium.org/759823006/diff/40001/src/serialize.cc
File src/serialize.cc (right):
https://codereview.chromium.org/759823006/diff/40001/src/serialize.cc#newcode817
src/serialize.cc:817: address = Allocate(space_number, size +
kPointerSize);
You should only need to add kPointerSize if not a 64bit architecture
(this is what the Heap::AllocateXXX calls do).
https://codereview.chromium.org/759823006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
