https://codereview.chromium.org/759823006/diff/40001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/759823006/diff/40001/src/heap/heap.cc#newcode1833
src/heap/heap.cc:1833: return EnsureDoubleAligned(this, object, size);
On 2014/11/26 18:59:49, Yang wrote:
On 2014/11/26 17:44:40, rmcilroy wrote:
> Could you add an ASSERT(object->NeedsToEnsureDoubleAlignment()) in
> EnsureDoubleAligned to ensure that the list in
NeedsToEnsureDoubleAlignment
> keeps in sync with objects which call EnsureDoubleAligned during
allocation.
Unfortunately, at this point, the object is no more than an
allocation. It
doesn't have a map yet, so we can't check for its object type.
I could add a DCHECK(object->NeedsToEnsureDoubleAlignment) at the call
sites
(AllocateFixedDoubleArray etc.) after the map is set, though.
Right enough. Your suggestion stgt. It doesn't quite capture the check,
but would hopefully help someone realise they should add to this list if
adding a new double aligned object.
https://codereview.chromium.org/759823006/diff/40001/src/serialize.cc
File src/serialize.cc (right):
https://codereview.chromium.org/759823006/diff/40001/src/serialize.cc#newcode817
src/serialize.cc:817: address = Allocate(space_number, size +
kPointerSize);
On 2014/11/26 18:59:49, Yang wrote:
On 2014/11/26 17:44:40, rmcilroy wrote:
> You should only need to add kPointerSize if not a 64bit architecture
(this is
> what the Heap::AllocateXXX calls do).
I think this entire if-branch can be omitted for 64bit archs?
agreed.
https://codereview.chromium.org/759823006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
