very nice. lgtm % style nits
https://codereview.chromium.org/765473006/diff/1/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/765473006/diff/1/src/objects-inl.h#newcode6727
src/objects-inl.h:6727: DCHECK(chars && length > 0);
Style nit: chars != nullptr.
Why 'length > 0', not 'length >= 0'?
https://codereview.chromium.org/765473006/diff/1/src/objects-inl.h#newcode6738
src/objects-inl.h:6738: DCHECK(chars && length > 0);
Ditto
https://codereview.chromium.org/765473006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
