https://codereview.chromium.org/765473006/diff/1/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/765473006/diff/1/src/objects-inl.h#newcode6727
src/objects-inl.h:6727: DCHECK(chars && length > 0);
On 2014/11/27 07:23:05, Dmitry Lomov (chromium) wrote:
Style nit: chars != nullptr.
Why 'length > 0', not 'length >= 0'?
Well there's no harm in it being an empty loop, but that path wouldn't
be taken as WriteUtf16() asserts that length > 0, I thought it would be
good to keep the assertions similar.
Done
https://codereview.chromium.org/765473006/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/765473006/diff/1/src/parser.cc#newcode5350
src/parser.cc:5350: *hash = running_hash;
On 2014/11/27 07:49:58, Dmitry Lomov (chromium) wrote:
Note that the actual hash value you get here is different from the
hash of the
string computed by ComputeUtf8Hash, but that is ok since this hash is
used
consistently in templates.
Probably add a comment explaining this.
Done
https://codereview.chromium.org/765473006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
