I would suggest using two bools instead of encoding the left/right values into a bool. Otherwise lgtm.
http://codereview.chromium.org/266050/diff/4001/4003 File src/runtime.cc (right): http://codereview.chromium.org/266050/diff/4001/4003#newcode3596 Line 3596: CONVERT_CHECKED(Smi, trimKind, args[1]); Using two boolean arguments instead of encoding the value into an integer would simplify the code. http://codereview.chromium.org/266050 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
