LGTM - thanks for the patch.
http://codereview.chromium.org/266050/diff/5002/6002 File src/runtime.cc (right): http://codereview.chromium.org/266050/diff/5002/6002#newcode3610 Line 3610: while (right > left && IsTrimWhiteSpace(s->Get(right-1))) Please add spaces around '-' and braces around multi-line if statement body. http://codereview.chromium.org/266050/diff/5002/6001 File test/mjsunit/third_party/string-trim.js (right): http://codereview.chromium.org/266050/diff/5002/6001#newcode32 Line 32: // Based on LayoutTests/fast/js/script-tests/string-trim.js I think the test files should conform to the formatting guidelines too, in which case in this file the comments need to be reformatted so they are within 80 characters, start with a capital letter and end with a full stop and have at least two spaces before and one space after the //. Also indentation should be two characters. http://codereview.chromium.org/266050 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
