https://codereview.chromium.org/753373003/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/753373003/diff/1/include/v8.h#newcode1827
include/v8.h:1827: * uses a inline property on the object to store the
identity hash.
a inline -> an inline
https://codereview.chromium.org/753373003/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/753373003/diff/1/src/api.cc#newcode4240
src/api.cc:4240: DCHECK(!self->IsSymbol() || self->HasHashCode());
why checking self->HasHashCode()?
just remove this DCHECK?
https://codereview.chromium.org/753373003/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/753373003/diff/1/test/cctest/test-api.cc#newcode3047
test/cctest/test-api.cc:3047: CHECK_EQ(hash, hash3);
can you also test symbols from JS:
v8::Handle<Value> js_symbol = CompileRun("Symbol('foo')");
https://codereview.chromium.org/753373003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
