LGTM once all comments are addressed.
https://codereview.chromium.org/753373003/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/753373003/diff/1/src/api.cc#newcode4240
src/api.cc:4240: DCHECK(!self->IsSymbol() || self->HasHashCode());
On 2014/12/01 15:49:17, aandrey wrote:
why checking self->HasHashCode()?
just remove this DCHECK?
agree.
https://codereview.chromium.org/753373003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
