Updates:
Labels: -Type-Bug Type-FeatureRequest
Comment #4 on issue 3731 by [email protected]: V8's gyp files should honor
dcheck_always_on=1
https://code.google.com/p/v8/issues/detail?id=3731
Here's a patch which allows V8 to run on Linux x64 in Release mode with
asserts enabled via dcheck_always_on=1. Chromium already #defines
DCHECK_ALWAYS_ON when compiling V8 with this gyp variable set, so no gyp
changes are needed on V8's side.
It could be nicer. Ideally most of the "#ifdef DEBUG" statements throughout
V8's code would be changed to test DCHECK_IS_ON, or a similar #define. When
making similar changes to Blink some time ago, the methodology was to leave
printing-only code under a separate #define (enabling logging) but to put
all of the other debug-only code under the DCHECK_IS_ON #define.
jochen@, would you be willing to marshal this through V8's testing and
review process? I haven't built V8 independently of Chromium in a long
time. Please take this bug from me if so, but otherwise please tell me how
you'd like me to proceed with this patch. Thanks.
Attachments:
dcheck-always-on.patch 57.6 KB
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
