Some comments.
http://codereview.chromium.org/264047/diff/1/2 File .gitignore (right): http://codereview.chromium.org/264047/diff/1/2#newcode17 Line 17: d8 Did you really want to make these changes to everyone? They look good - these are files we want to ignore. http://codereview.chromium.org/264047/diff/1/5 File src/execution.h (right): http://codereview.chromium.org/264047/diff/1/5#newcode222 Line 222: #endif What is the point of this, if both limits are the same? http://codereview.chromium.org/264047/diff/1/7 File test/cctest/test-api.cc (right): http://codereview.chromium.org/264047/diff/1/7#newcode731 Line 731: int32_t value = Add a comment that the type casts are only to make the compiler happy in the cases that aren't actually run, due to the guard. Otherwise, it is confusing - the type casts actually do the wrong thing, if they do anything. http://codereview.chromium.org/264047/diff/1/8 File test/cctest/test-assembler-x64.cc (right): http://codereview.chromium.org/264047/diff/1/8#newcode84 Line 84: #ifdef _WIN64 Why not use a platform dependent macro argument_1_ = rdx or rsi, argument_2_ = ... Or else static constant register variables arg1 and arg2. http://codereview.chromium.org/264047 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
