http://codereview.chromium.org/264047/diff/1/2 File .gitignore (right):
http://codereview.chromium.org/264047/diff/1/2#newcode17 Line 17: d8 They are either auto-generated files (idp/pdb) or standard temporary files (i.e., also auto-generated by, e.g., vi and emacs). I see no reason not to have everyone's git ignore them. http://codereview.chromium.org/264047/diff/1/5 File src/execution.h (right): http://codereview.chromium.org/264047/diff/1/5#newcode222 Line 222: #endif On 2009/10/13 09:15:03, William Hesse wrote: > What is the point of this, if both limits are the same? Good point. I'm not sure they should be the same, but for now, I'll remove the ifdef. http://codereview.chromium.org/264047/diff/1/7 File test/cctest/test-api.cc (right): http://codereview.chromium.org/264047/diff/1/7#newcode731 Line 731: int32_t value = Will do. http://codereview.chromium.org/264047/diff/1/8 File test/cctest/test-assembler-x64.cc (right): http://codereview.chromium.org/264047/diff/1/8#newcode84 Line 84: #ifdef _WIN64 A good idea. They should probably be defined somewhere central. I would prefer the MacroAssembler, but it won't help in the test case, since we test the Assembler directly. For now, I'll define it in this file only. http://codereview.chromium.org/264047 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
