On 2014/12/02 at 20:54:50, caitpotter88 wrote:
On 2014/12/02 20:48:06, arv wrote:
> PTAL
>
> I added a LiteralBuffer and now capture all raw characters during
> ScanTemplateSpan. This is partially based on an early patchset by
Caitlin:
>
>
https://codereview.chromium.org/663683006/diff/80001/src/scanner.h?context=100&column_width=80&tab_spaces=8
I was just reading it --- I think updating the raw literal during
Advance() is
pretty novel and a much simpler way to do it, it looks like it should work
well.
Even though the raw literal recording is now unrelated to other escape
sequence parsing, I think it would be a good idea to add some extra TV/TRV
tests
which depend on --harmony-unicode, just to make sure it is working as
expected
(just in case we're using PushBack() in there for some reason, or something
like
that).
Good idea. I was a bit worried about PushBack too. I added a DCHECK to make
sure
that we do not do a PushBack when we are capturing raw literals.
I'll have to rebase before adding the harmony-unicode tests.
https://codereview.chromium.org/768203002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
