On 2014/12/02 at 21:37:36, caitpotter88 wrote:
https://codereview.chromium.org/768203002/diff/40001/src/scanner.h
File src/scanner.h (right):
https://codereview.chromium.org/768203002/diff/40001/src/scanner.h#newcode582
src/scanner.h:582: DCHECK(ch < 0 || !capturing_raw_literal_);
I feel like PushBack() is okay --- it's more just that you want to make
sure
PushBack() is closely followed by a ReduceRawLiteralLength() if raw
literals are
being captured, am I wrong about that?
You are right that PushBack is OK if ReduceRawLiteralLength is called
afterwards. Two options:
1. Keep as is with the DCHECK, basically disabling PushBack during
ScanTemplateSpan.
2. Add code in PushBack that calls ReduceRawLiteralLength if needed.
https://codereview.chromium.org/768203002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
