https://codereview.chromium.org/767253002/diff/80001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/767253002/diff/80001/src/heap/heap.cc#newcode2360
src/heap/heap.cc:2360: Map::OwnsDescriptors::encode(true);
| Map::Counter::encode(Map::kRetainingCounterStart)
https://codereview.chromium.org/767253002/diff/80001/src/ia32/builtins-ia32.cc
File src/ia32/builtins-ia32.cc (right):
https://codereview.chromium.org/767253002/diff/80001/src/ia32/builtins-ia32.cc#newcode173
src/ia32/builtins-ia32.cc:173: __ cmp(esi, Map::kSlackTrackingCounterEnd
+ 1);
We should compare against Map::kSlackTrackingCounterEnd here which is
the last value meaning that the slack tracking is still active. Same for
other platforms.
https://codereview.chromium.org/767253002/diff/80001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/767253002/diff/80001/src/objects.h#newcode5668
src/objects.h:5668: class Counter : public BitField<bool, 28, 4> {};
Please add a comment what is this counter for and please mention that
the slack tracking is considered enabled when the counter is in the
range [kSlackTrackingCounterStart, kSlackTrackingCounterEnd].
https://codereview.chromium.org/767253002/diff/80001/src/objects.h#newcode5669
src/objects.h:5669: static const int kSlackTrackingCounterStart = 15;
Counter::kMax
https://codereview.chromium.org/767253002/diff/80001/src/objects.h#newcode5678
src/objects.h:5678: (kRetainingCounterEnd >> (Counter::kSize - 1)));
I think we don't need this asserts since we don't have
|done_inobject_slack_tracking| bit anymore and we compare counter values
against ranges explicitly.
https://codereview.chromium.org/767253002/diff/80001/src/objects.h#newcode7370
src/objects.h:7370: // counter in the initial_map and clear the
|is_inobject_slack_tracking_off|
We don't have such a flag.
https://codereview.chromium.org/767253002/diff/80001/src/objects.h#newcode7392
src/objects.h:7392: Map::kSlackTrackingCounterStart -
Map::kSlackTrackingCounterEnd;
I think we need + 1 here, since the range in inclusive at both ends.
https://codereview.chromium.org/767253002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
