On 2014/12/05 14:49:09, Igor Sheludko wrote:
lgtm with a nit:
https://codereview.chromium.org/767253002/diff/100001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/767253002/diff/100001/src/objects.cc#newcode10317
src/objects.cc:10317: DCHECK(map->counter() >=
Map::kSlackTrackingCounterEnd);
I'm afraid that this assert could fail if we get here from
JSConstructStub. I
would say:
DCHECK(map->counter() >= Map::kSlackTrackingCounterEnd - 1);
Fixed it, thanks.
https://codereview.chromium.org/767253002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
