lgtm with a note.
https://codereview.chromium.org/782493002/diff/1/src/compiler/mips/code-generator-mips.cc
File src/compiler/mips/code-generator-mips.cc (right):
https://codereview.chromium.org/782493002/diff/1/src/compiler/mips/code-generator-mips.cc#newcode179
src/compiler/mips/code-generator-mips.cc:179: __ Branch(ool->entry(),
ls, i.InputRegister(1), Operand(offset)); \
As I understand the operands were replaced in the Branch so the
Condition should be negated.
I think !hs == lo not ls. For the following Branches too. And for 64
bits too.
https://codereview.chromium.org/782493002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
