https://codereview.chromium.org/782493002/diff/1/src/compiler/mips/code-generator-mips.cc
File src/compiler/mips/code-generator-mips.cc (right):
https://codereview.chromium.org/782493002/diff/1/src/compiler/mips/code-generator-mips.cc#newcode174
src/compiler/mips/code-generator-mips.cc:174: __ Branch(ool->entry(),
hs, offset, i.InputOperand(1)); \
Very nice, I missed it.
https://codereview.chromium.org/782493002/diff/1/src/compiler/mips/code-generator-mips.cc#newcode174
src/compiler/mips/code-generator-mips.cc:174: __ Branch(ool->entry(),
hs, offset, i.InputOperand(1)); \
On 2014/12/04 16:05:56, paul.l... wrote:
micro-optimization possible by putting the addu in the
branch-delay-slot. The
change to 'at' won't matter if the branch is taken. 3 more spots in
the below
macros. And in mips64.
Done.
https://codereview.chromium.org/782493002/diff/1/src/compiler/mips/code-generator-mips.cc#newcode210
src/compiler/mips/code-generator-mips.cc:210: auto value =
i.Input##width##Register(2); \
On 2014/12/04 16:05:56, paul.l... wrote:
If you do use the delay slot of the branch, you might want to move
this variable
declaration above the branch, so relation of Branch() and addu() is
very clear,
Done.
https://codereview.chromium.org/782493002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
