Hi Jakob,
Okay patch set 3 contains the ports, along with the issues found/fixed while
making the ports.
Patch set 4 contains the response to your last round, thx for that.
Patch set 5 contains two changes that won't be checked in, but they allow
the
rest of the porting team to verify that all tests pass as they make their
port.
It consists of the flag being turned on, and one debug test disabled while I
debug why it fails.
I'll alert mips/x87 folks.
https://codereview.chromium.org/767743002/diff/60001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/767743002/diff/60001/src/code-stubs-hydrogen.cc#newcode2091
src/code-stubs-hydrogen.cc:2091: IfBuilder if_correct_map(this);
On 2014/12/03 13:22:17, Jakob wrote:
nit: please don't shadow variables. (There's already an
"if_correct_map" builder
in the outer scope.)
Done.
https://codereview.chromium.org/767743002/diff/60001/src/code-stubs-hydrogen.cc#newcode2098
src/code-stubs-hydrogen.cc:2098: TailCallMiss(receiver, name, slot,
vector, keyed_load);
On 2014/12/03 13:22:17, Jakob wrote:
nit: drop this...
Done.
https://codereview.chromium.org/767743002/diff/60001/src/code-stubs-hydrogen.cc#newcode2102
src/code-stubs-hydrogen.cc:2102: if_receiver_heap_object.Else();
On 2014/12/03 13:22:17, Jakob wrote:
...and this, and let all control flow paths fall through to a single
TailCallMiss() at the end.
Done. I removed these two and changed the caller BuildCodeStub() methods
to handle the miss.
https://codereview.chromium.org/767743002/diff/60001/src/code-stubs-hydrogen.cc#newcode2192
src/code-stubs-hydrogen.cc:2192: // Check if the IC in generic state.
On 2014/12/03 13:22:17, Jakob wrote:
nit: missing "is"
wow, good eye :D
https://codereview.chromium.org/767743002/diff/60001/src/code-stubs-hydrogen.cc#newcode2204
src/code-stubs-hydrogen.cc:2204: // We never return here, it is a tail
call.
On 2014/12/03 13:22:17, Jakob wrote:
nit: move this comment after the call please.
Done.
https://codereview.chromium.org/767743002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
