Still LGTM, with one nit and a reminder about the flag.
https://codereview.chromium.org/767743002/diff/60001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/767743002/diff/60001/src/code-stubs-hydrogen.cc#newcode2192
src/code-stubs-hydrogen.cc:2192: // Check if the IC in generic state.
On 2014/12/08 12:44:24, mvstanton wrote:
On 2014/12/03 13:22:17, Jakob wrote:
> nit: missing "is"
wow, good eye :D
Nah, just OCD ;-)
https://codereview.chromium.org/767743002/diff/150001/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/767743002/diff/150001/src/arm/lithium-codegen-arm.cc#newcode4037
src/arm/lithium-codegen-arm.cc:4037: // number of instructions for the
constant pool load.
nit: join this into the previous line (again below)
https://codereview.chromium.org/767743002/diff/150001/src/ic/arm/stub-cache-arm.cc
File src/ic/arm/stub-cache-arm.cc (right):
https://codereview.chromium.org/767743002/diff/150001/src/ic/arm/stub-cache-arm.cc#newcode115
src/ic/arm/stub-cache-arm.cc:115: DCHECK(!AreAliased(receiver, name,
scratch, extra, extra2, extra3));
LGTM!
https://codereview.chromium.org/767743002/diff/190001/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/767743002/diff/190001/src/flag-definitions.h#newcode251
src/flag-definitions.h:251: DEFINE_BOOL(vector_ics, true, "support
vector-based ics")
Reminder: don't forget to undo this change (and the one in
mjsunit.status) before landing.
https://codereview.chromium.org/767743002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
