Added pushing debug context to top of stack by entering debug scope and
suppressing debug events in process compile event function.
https://codereview.chromium.org/781623004/diff/1/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/781623004/diff/1/src/debug.cc#newcode2485
src/debug.cc:2485: Handle<GlobalObject> global = in_debug_scope() ?
Handle<GlobalObject>(debug_context()->global_object()) :
Handle<GlobalObject>(isolate_->global_object());
On 2014/12/08 07:19:28, yurys wrote:
This way we will create debugger objects in the user context. This is
dangerous
since the user code can override almost everything and we may at some
point end
up executing user code in the debugger context. Please make sure to
enter
debugger context first if you need to create an object for the
debugger.
Done.
https://codereview.chromium.org/781623004/diff/1/src/debug.cc#newcode2860
src/debug.cc:2860: if (event_listener_.is_null()) return;
On 2014/12/08 10:55:51, yurys wrote:
I believe you can reenter debug context here if it is not on the top
of the
stack. Also it should be possible to use SuppressDebug scope here.
Done.
https://codereview.chromium.org/781623004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
