lgtm
https://codereview.chromium.org/781623004/diff/40001/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/781623004/diff/40001/src/debug.cc#newcode2864
src/debug.cc:2864: DebugScope debug_scope(this);
You might want to skip this if debug context is on top of the stack but
we most likely won't receive compile events from debug context here, so
I think it should be fine as is.
https://codereview.chromium.org/781623004/diff/40001/test/mjsunit/debug-clearbreakpointgroup.js
File test/mjsunit/debug-clearbreakpointgroup.js (right):
https://codereview.chromium.org/781623004/diff/40001/test/mjsunit/debug-clearbreakpointgroup.js#newcode43
test/mjsunit/debug-clearbreakpointgroup.js:43: muteListener = true;
try/finally
https://codereview.chromium.org/781623004/diff/40001/test/mjsunit/debug-compile-event.js
File test/mjsunit/debug-compile-event.js (right):
https://codereview.chromium.org/781623004/diff/40001/test/mjsunit/debug-compile-event.js#newcode86
test/mjsunit/debug-compile-event.js:86: var msg = eval('(' + json +
')');
try/finally
https://codereview.chromium.org/781623004/diff/40001/test/mjsunit/debug-evaluate-with-context.js
File test/mjsunit/debug-evaluate-with-context.js (right):
https://codereview.chromium.org/781623004/diff/40001/test/mjsunit/debug-evaluate-with-context.js#newcode35
test/mjsunit/debug-evaluate-with-context.js:35: if (event ==
Debug.DebugEvent.AfterCompile ||
should it be
if (event !== Debug.DebugEvent.DebugBreak)
return
?
https://codereview.chromium.org/781623004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
