https://codereview.chromium.org/770333005/diff/20001/src/harmony-classes.js
File src/harmony-classes.js (right):
https://codereview.chromium.org/770333005/diff/20001/src/harmony-classes.js#newcode21
src/harmony-classes.js:21: ['Function.prototype.toMethod',
Looks like this is from some other patch?
https://codereview.chromium.org/770333005/diff/20001/src/harmony-regexp.js
File src/harmony-regexp.js (right):
https://codereview.chromium.org/770333005/diff/20001/src/harmony-regexp.js#newcode17
src/harmony-regexp.js:17: throw MakeTypeError('home_object_non_object',
Wrong error message.
https://codereview.chromium.org/770333005/diff/20001/src/harmony-regexp.js#newcode30
src/harmony-regexp.js:30:
%DefineAccessorPropertyUnchecked($RegExp.prototype, 'flags',
RegExpGetFlags,
You should pass 'undefined' here instead of NoOpSetter.
Regexp.prototype.flags do not have a setter.
https://codereview.chromium.org/770333005/diff/20001/test/mjsunit/harmony/regexp-flags.js
File test/mjsunit/harmony/regexp-flags.js (right):
https://codereview.chromium.org/770333005/diff/20001/test/mjsunit/harmony/regexp-flags.js#newcode5
test/mjsunit/harmony/regexp-flags.js:5: // Flags: --harmony-regexps
Also add test that validates properties of Regexp.prototype.flag from
its property descriptor (has getter, has no setter)
https://codereview.chromium.org/770333005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
