On 2014/12/10 08:23:31, mathias wrote:
https://codereview.chromium.org/770333005/diff/20001/src/harmony-classes.js File src/harmony-classes.js (right):
https://codereview.chromium.org/770333005/diff/20001/src/harmony-classes.js#n...
src/harmony-classes.js:21: ['Function.prototype.toMethod', On 2014/12/09 23:39:12, Dmitry Lomov (chromium) wrote: > Looks like this is from some other patch?
It was intentional; I wanted to re-use the same error message. Updated the
patch
now to use a new, separate error message.
https://codereview.chromium.org/770333005/diff/20001/test/mjsunit/harmony/reg...
File test/mjsunit/harmony/regexp-flags.js (right):
https://codereview.chromium.org/770333005/diff/20001/test/mjsunit/harmony/reg...
test/mjsunit/harmony/regexp-flags.js:7: assertEquals('',
RegExp.prototype.flags);
On 2014/12/10 02:54:50, arv wrote:
> Shouldn't this throw since the prototype object does not have
[[OriginalFlags]]?
>
> I guess this is a really a bug in our implementation of
RegExp.prototype.global.
> But once/if we fix that then this test will start to fail.
Ack. What do you want to do here – fix the separate bug later and leave the
test
for now? Or just remove this test?
Remove the test. It is incorrect per spec.What you really want to test here is subclasses of RegExp but we do not support
that currently. https://codereview.chromium.org/770333005/ -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
