https://codereview.chromium.org/768633002/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/768633002/diff/20001/src/objects.cc#newcode8174
src/objects.cc:8174: return; // StoreAnywhere() makes sure there are no
duplicates.
What is StoreAnywhere()?
https://codereview.chromium.org/768633002/diff/20001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/768633002/diff/20001/src/objects.h#newcode2602
src/objects.h:2602: bool may_be_duplicate = false);
Please use enum with descriptive name instead of bool. E.g. ALWAYS_ADD,
ADD_IF_NOT_FOUND.
https://codereview.chromium.org/768633002/diff/20001/src/objects.h#newcode2607
src/objects.h:2607: inline int length() const;
Nit: I personally don't like non-virtual overrides because they make
code harder to read: to see what x->get(i) does, one needs to remember
whether x is WeakFixedArray or FixedArray. I would use x->Get(i) and
x->Length() for WeakFixedArray methods. Feel free to change or leave as
is.
https://codereview.chromium.org/768633002/diff/20001/src/runtime/runtime-object.cc
File src/runtime/runtime-object.cc (right):
https://codereview.chromium.org/768633002/diff/20001/src/runtime/runtime-object.cc#newcode999
src/runtime/runtime-object.cc:999: if
(isolate->IsInternallyUsedPropertyName(name_from_hidden_proto)) {
Shouldn't this also check (filter & STRING) == 0?
https://codereview.chromium.org/768633002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
