https://codereview.chromium.org/768633002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/768633002/diff/1/src/objects.cc#newcode8112
src/objects.cc:8112: Handle<FixedArray>::cast(array)->set(index +
kReservedFieldCount, *cell);
So kReservedFieldCount is just an internal header? What about naming it
kFirstIndex like in the other arrays?
https://codereview.chromium.org/768633002/diff/1/src/objects.cc#newcode8158
src/objects.cc:8158: int first_index = array->last_used_index();
Seems like you would want to start at last_used_index+1?
https://codereview.chromium.org/768633002/diff/1/src/objects.cc#newcode8168
src/objects.cc:8168: if (i == array->length()) i = 0;
i = (i + 1) % array->length();
https://codereview.chromium.org/768633002/diff/1/src/objects.cc#newcode9791
src/objects.cc:9791: if (!WeakFixedArray::StoreAnywhere(array, user)) {
Handle<WFA> new_array = WFA::Add(array, user);
must_store = !new_array.is_identical_to(array);
https://codereview.chromium.org/768633002/diff/1/src/objects.cc#newcode9808
src/objects.cc:9808: Handle<Object> maybe_array =
JSObject::GetProperty(&it).ToHandleChecked();
JSObject::GetProperty(prototype, symbol);
https://codereview.chromium.org/768633002/diff/1/src/objects.cc#newcode9837
src/objects.cc:9837: if (!back->IsMap()) return true;
That would include maps that aren't part of a transition tree right?
Including slow-mode maps.
https://codereview.chromium.org/768633002/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/768633002/diff/1/src/objects.h#newcode2601
src/objects.h:2601: static bool StoreAnywhere(Handle<WeakFixedArray>
array,
What about combining StoreAnywhere with GrowAndStore into
Handle<WFA> Add(Handle<WFA>, ...)?
https://codereview.chromium.org/768633002/diff/1/src/objects.h#newcode2607
src/objects.h:2607: void Delete(Handle<HeapObject> value);
And then rename to Remove to match Add.
https://codereview.chromium.org/768633002/diff/1/src/objects.h#newcode2627
src/objects.h:2627: friend class Factory; // For kReservedFieldCount.
Just move the method onto WeakFixedArray rather than having this
indirection over the factory. Just like DescriptorArray::Allocate. In
that case, you don't need to friend anything.
https://codereview.chromium.org/768633002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
