Reviewers: adamk,
Description:
Remove invalid DCHECK from AddSubstring
The input string is not necessarily zero terminated
BUG=chromium:443230
[email protected]
LOG=n
Please review this at https://codereview.chromium.org/795383003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -1 lines):
M src/utils.cc
Index: src/utils.cc
diff --git a/src/utils.cc b/src/utils.cc
index
40c8b404fdfd57ebb7ce3a7db98a814705aa5994..76b5a078f56deb9b61f84ffea2f27677a3823bf3
100644
--- a/src/utils.cc
+++ b/src/utils.cc
@@ -29,7 +29,6 @@ void SimpleStringBuilder::AddString(const char* s) {
void SimpleStringBuilder::AddSubstring(const char* s, int n) {
DCHECK(!is_finalized() && position_ + n <= buffer_.length());
- DCHECK(static_cast<size_t>(n) <= strlen(s));
MemCopy(&buffer_[position_], s, n * kCharSize);
position_ += n;
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
