It looks to me like the caller that's triggering this DCHECK,
NativesStore::NameFromId, is abusing the SimpleStringBuilder API. All other
callers of SimpleStringBuilder are using it with NUL-terminated strings,
which
is what Finalize() returns and what AddSubstring is documented to deal with
("The input string must have enough characters"). NameFromId really just
wants a
Vector.
It seems like it should be easy enough for NameForId to simply shove the
correct
bytes into the Vector it's returning.
https://codereview.chromium.org/795383003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
