sorry, I have a hard time figuring out what this CL does :-/
https://codereview.chromium.org/807693003/diff/1/src/compiler/node-matchers.h
File src/compiler/node-matchers.h (right):
https://codereview.chromium.org/807693003/diff/1/src/compiler/node-matchers.h#newcode208
src/compiler/node-matchers.h:208: struct JSCallFunctionMatcher FINAL :
public NodeMatcher {
i see that this is done all over the place, but these shouldn't be
structs...
https://codereview.chromium.org/807693003/diff/1/src/compiler/node-matchers.h#newcode227
src/compiler/node-matchers.h:227: };
are you copying the matchers around? If yes, there should be explicit
copy/assignment operators, if not, the DISALLOW_COPY_AND_ASSIGN() macro
should be used
https://codereview.chromium.org/807693003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
