Reviewers: Igor Sheludko,
Description:
[turbofan] Turn DCHECK for fixed slot index into a CHECK.
This is a temporary workaround to ensure that we crash in release mode
instead of running into undefined behavior.
BUG=chromium:444681
LOG=y
[email protected]
Please review this at https://codereview.chromium.org/800713006/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -1 lines):
M src/compiler/instruction.h
Index: src/compiler/instruction.h
diff --git a/src/compiler/instruction.h b/src/compiler/instruction.h
index
41cda82fc1b204921532ca2defd17baa40bd1a0b..4ce89ddd97ce193118d9736cfd5058c305e034ef
100644
--- a/src/compiler/instruction.h
+++ b/src/compiler/instruction.h
@@ -129,7 +129,8 @@ class UnallocatedOperand : public InstructionOperand {
value_ |= VirtualRegisterField::encode(kInvalidVirtualRegister);
value_ |= BasicPolicyField::encode(policy);
value_ |= index << FixedSlotIndexField::kShift;
- DCHECK(this->fixed_slot_index() == index);
+ // TODO(dcarney): 2^10 is not enough for the fixed slot index.
+ CHECK(this->fixed_slot_index() == index);
}
UnallocatedOperand(ExtendedPolicy policy, int index)
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
