LGTM.

http://codereview.chromium.org/305005/diff/1/3
File src/ia32/fast-codegen-ia32.cc (right):

http://codereview.chromium.org/305005/diff/1/3#newcode184
Line 184: __ pop(eax);
We may avoid a memory access when discarding the result by just doing
sth. like

__ add(esp, 4)

here. However, it uses 3 bytes of space instead of 1.

http://codereview.chromium.org/305005

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to