http://codereview.chromium.org/305005/diff/1/3 File src/ia32/fast-codegen-ia32.cc (right):
http://codereview.chromium.org/305005/diff/1/3#newcode184 Line 184: __ pop(eax); Yes. I didn't worry about it because: Here we're not discarding the result, but the global object left on the stack by the IC. We should consider replacing the IC call with a runtime call anyway. We should consider making the IC drop the receiver (and take it in a register anyway). Ultimately, all real discarded values (of subexpressions) should not ever be materialized in the first place. http://codereview.chromium.org/305005 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
