lgtm
the only non-pythonic (sort of) thing I see is the capitalization of free
functions.
https://codereview.chromium.org/835903003/diff/20001/tools/push-to-trunk/generate_version.py
File tools/push-to-trunk/generate_version.py (right):
https://codereview.chromium.org/835903003/diff/20001/tools/push-to-trunk/generate_version.py#newcode21
tools/push-to-trunk/generate_version.py:21: def Main():
nit: why capitalized?
https://codereview.chromium.org/835903003/diff/20001/tools/push-to-trunk/generate_version.py#newcode53
tools/push-to-trunk/generate_version.py:53: with open(VERSION_CC, "r")
as f:
yes, this "with" statement is important on Windows, as file *must* be
closed before overwriting.
https://codereview.chromium.org/835903003/diff/20001/tools/push-to-trunk/generate_version.py#newcode55
tools/push-to-trunk/generate_version.py:55: def Sub(line, definition,
substitute):
i wouldn't make this a function
https://codereview.chromium.org/835903003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
