LGTM
On 2015/01/05 14:46:09, tandrii_google wrote:
the only non-pythonic (sort of) thing I see is the capitalization of free
functions.
Since most code in V8 is C++, we tend to apply the C++ style guide's
formatting
rules to scripts written in other languages. Personally, I'm happy with
this,
because I think consistency within a project is more valuable than
consistency
with other projects using the same language.
https://codereview.chromium.org/835903003/diff/40001/tools/push-to-trunk/generate_version.py
File tools/push-to-trunk/generate_version.py (right):
https://codereview.chromium.org/835903003/diff/40001/tools/push-to-trunk/generate_version.py#newcode54
tools/push-to-trunk/generate_version.py:54: text = f.read()
More pythonification:
with open(VERSION_CC, "r") as f:
for line in f:
...
Note that with the above, |line| will still have a trailing '\n'.
https://codereview.chromium.org/835903003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
