https://codereview.chromium.org/853703002/diff/60001/src/x64/assembler-x64.cc
File src/x64/assembler-x64.cc (right):
https://codereview.chromium.org/853703002/diff/60001/src/x64/assembler-x64.cc#newcode63
src/x64/assembler-x64.cc:63: if (cpu.is_atom()) FLAG_intel_atom = true;
On 2015/01/19 05:39:25, Benedikt Meurer wrote:
Modifying flags this way is a bad idea, and it also defeats the
purpose of the
flag completely, because now whenever the CPU class detects an ATOM,
the
intel-atom flag will be forcibly true.
Maybe I miss something?
The logic here: the intel_atom flag is FALSE by default. It is only true
if CPU detects an ATOM or you require it by using "--intel_atom" flag.
The latter eases the test of ATOM specific code path on non-ATOM
devices.
https://codereview.chromium.org/853703002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
