https://codereview.chromium.org/853703002/diff/60001/src/x64/assembler-x64.cc
File src/x64/assembler-x64.cc (right):
https://codereview.chromium.org/853703002/diff/60001/src/x64/assembler-x64.cc#newcode63
src/x64/assembler-x64.cc:63: if (cpu.is_atom()) FLAG_intel_atom = true;
Yes, but you cannot generally test the backend code independent of the
CPU that you are running on. If you happen to run on something that
claims to be an ATOM, you'll always be forced into the ATOM code path. A
similar problem exists for the ATOM CpuFeatures flag, however. Ideally
the --intel-atom flag would forcibly enable the ATOM code path, while
--nointel-atom forcibly disables it, and autodetection is only used if
neither flag is given. However that's not how our flags work.
So how about this solution: Add a string flag --mcpu=<cpu> with <cpu>
default to "auto". This can be used in general and is not limited to
this ATOM thing.
Sven, danno: WDYT?
https://codereview.chromium.org/853703002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
