On 2015/01/20 14:57:22, jbramley wrote:
https://codereview.chromium.org/863633002/diff/80001/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):
https://codereview.chromium.org/863633002/diff/80001/src/arm/simulator-arm.cc#newcode1922
src/arm/simulator-arm.cc:1922: const uint64_t kDefaultNaN =
V8_UINT64_C(0x7FF8000000000000);
We already have kFP64DefaultNaN (in src/arm64/instructions-arm64.h).
https://codereview.chromium.org/863633002/diff/120001/src/arm64/lithium-codegen-arm64.cc
File src/arm64/lithium-codegen-arm64.cc (right):
https://codereview.chromium.org/863633002/diff/120001/src/arm64/lithium-codegen-arm64.cc#newcode3610
src/arm64/lithium-codegen-arm64.cc:3610: DeoptimizeIf(eq, instr, "hole");
Untested suggestion:
__ Ldr(scratch, mem_op);
__ Eor(scratch, scratch, kHoleNaNInt64);
__ DeoptimizeIfZero(scratch, instr, "hole");
It should assemble to just three instructions, since kHoleNaNInt64 is
representable as a logical immediate:
ldr x16, [mem_op]
eor x16, x16, #0x7ff000007ff00000
cbz x16, deopt_label
By the way, I'd be happy to produce a follow-up patch to make these
changes; it
doesn't need to hold up this one.
https://codereview.chromium.org/863633002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
