Thanks a lot, fixed those.
https://codereview.chromium.org/863633002/diff/200001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/863633002/diff/200001/src/hydrogen-instructions.cc#newcode4056
src/hydrogen-instructions.cc:4056: switch (value()->opcode()) {
Fixed, thanks.
https://codereview.chromium.org/863633002/diff/200001/test/mjsunit/regress/regress-undefined-nan.js
File test/mjsunit/regress/regress-undefined-nan.js (right):
https://codereview.chromium.org/863633002/diff/200001/test/mjsunit/regress/regress-undefined-nan.js#newcode18
test/mjsunit/regress/regress-undefined-nan.js:18:
fixed_double_elements[0] = f_view[0];
On 2015/01/22 02:52:20, Vyacheslav Egorov (Google) wrote:
This regression test does not necessarily work as is on ia32. This
statement has
to be inside an optimized function to ensure transfer through xmm
registers.
If this hits runtime and uses FPU registers for transfer somewhere
(e.g. return
value of a function call).
If I add here:
var i32 = new Int32Array(fixed_double_elements.buffer);
assertEquals(i_view[0], i32[0]);
assertEquals(i_view[1], i32[1]);
to verify that test tests what it wants - this fails on ia32.debug
build.
Need smth like:
function opt_store() { fixed_double_elements[0] = f_view[0]; }
opt_store();
opt_store();
%OptimizeFunctionOnNextCall(opt_store);
opt_store();
to fix it.
Done.
https://codereview.chromium.org/863633002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
