LGTM with comments. The nodes per chunk number seems high. Isn't this going to waste too much space for most web pages?
This is getting complicated. I think we should be able to come up with something simpler than this? Maybe splitting this one list into multiple lists or something. Feel free to consider that in a separate change. http://codereview.chromium.org/327008/diff/1/3 File src/global-handles.cc (right): http://codereview.chromium.org/327008/diff/1/3#newcode236 Line 236: static const int kNodesPerChunk = (1 << 13) - 1; This seems like a lot of nodes per chunk? What is this number based on? http://codereview.chromium.org/327008/diff/1/2 File src/global-handles.h (right): http://codereview.chromium.org/327008/diff/1/2#newcode153 Line 153: // List of deallocated nodes. Even though they are deallocated, Could you update this comment with a bit more information. It took me a while to figure out the way |first_deallocated_| is always the node before |head_|. This deallocated list is an unused prefix of the list started at |head_| where |first_deallocated_| points to the end of the deallocated list. http://codereview.chromium.org/327008 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
