Mads, thanks a lot for comments.
http://codereview.chromium.org/327008/diff/1/3 File src/global-handles.cc (right): http://codereview.chromium.org/327008/diff/1/3#newcode236 Line 236: static const int kNodesPerChunk = (1 << 13) - 1; On 2009/10/23 12:45:21, Mads Ager wrote: > This seems like a lot of nodes per chunk? What is this number based on? No serious real reasons. Two factors: nodes are of 40 bytes for 32bit, so it's 320K (unless there are additional alignments), probably affordable on all machines even if it'd be 1M. Two: couple of times I saw numbers like 10.000s of global handles, so 8191 looked like a 'pragmatic' approximation. Once again, no hard data. http://codereview.chromium.org/327008/diff/1/2 File src/global-handles.h (right): http://codereview.chromium.org/327008/diff/1/2#newcode153 Line 153: // List of deallocated nodes. Even though they are deallocated, On 2009/10/23 12:45:21, Mads Ager wrote: > Could you update this comment with a bit more information. It took me a while > to figure out the way |first_deallocated_| is always the node before |head_|. > This deallocated list is an unused prefix of the list started at |head_| where > |first_deallocated_| points to the end of the deallocated list. Sure. Is it good enough? http://codereview.chromium.org/327008 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
