Reviewers: titzer,
Description:
Add missing FrameState to JSTypedLoweringTester.
[email protected]
TEST=cctest/test-js-typed-lowering/JSToNumberOfNumberOrOtherPrimitive
Please review this at https://codereview.chromium.org/862963002/
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-runtime-todo
Affected files (+6, -2 lines):
M test/cctest/cctest.status
M test/cctest/compiler/test-js-typed-lowering.cc
Index: test/cctest/cctest.status
diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status
index
2de99dd914705ef5f598f299ee78e41ca7b01cde..77e2082021c37a7178593c84cf12af8f4fd192ec
100644
--- a/test/cctest/cctest.status
+++ b/test/cctest/cctest.status
@@ -101,7 +101,6 @@
'test-api/Regress93759': [PASS, NO_VARIANTS],
'test-debug/DebugBreakOnExceptionInObserveCallback': [PASS, NO_VARIANTS],
'test-object-observe/DeliveryCallbackThrows': [PASS, NO_VARIANTS],
- 'test-js-typed-lowering/JSToNumberOfNumberOrOtherPrimitive': [PASS,
NO_VARIANTS],
# TODO(titzer): Triggers bug in late control reduction.
'test-run-inlining/InlineLoopGuardedEmpty': [SKIP],
Index: test/cctest/compiler/test-js-typed-lowering.cc
diff --git a/test/cctest/compiler/test-js-typed-lowering.cc
b/test/cctest/compiler/test-js-typed-lowering.cc
index
e23ad0cd169d091297556920d918e7378e70cc12..38867866ef518691dcdfe98f111e40b1c46f00e1
100644
--- a/test/cctest/compiler/test-js-typed-lowering.cc
+++ b/test/cctest/compiler/test-js-typed-lowering.cc
@@ -118,7 +118,12 @@ class JSTypedLoweringTester : public
HandleAndZoneScope {
Node* Unop(const Operator* op, Node* input) {
// JS unops also require context, effect, and control
- return graph.NewNode(op, input, context(), start(), control());
+ if (OperatorProperties::HasFrameStateInput(op)) {
+ return graph.NewNode(op, input, context(),
EmptyFrameState(context()),
+ start(), control());
+ } else {
+ return graph.NewNode(op, input, context(), start(), control());
+ }
}
Node* UseForEffect(Node* node) {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
