I don't really see the value this CL adds, but if it makes you happy...
whatever. LGTM.
One nit, though. We don't need no duplication.
https://codereview.chromium.org/864803002/diff/1/test/unittests/compiler/js-typed-lowering-unittest.cc
File test/unittests/compiler/js-typed-lowering-unittest.cc (right):
https://codereview.chromium.org/864803002/diff/1/test/unittests/compiler/js-typed-lowering-unittest.cc#newcode231
test/unittests/compiler/js-typed-lowering-unittest.cc:231: const double
kNaNs[] = {std::numeric_limits<double>::quiet_NaN(),
No.
https://codereview.chromium.org/864803002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
