https://codereview.chromium.org/856303002/diff/1/src/harmony-array.js
File src/harmony-array.js (right):
https://codereview.chromium.org/856303002/diff/1/src/harmony-array.js#newcode145
src/harmony-array.js:145: var iterable = GetMethod(items,
symbolIterator);
We now call items.[[Get]](symbolIterator) twice. The spec mandates that
it is only called once. The spec makes me sad that we cannot use for-of
loop here.
https://codereview.chromium.org/856303002/diff/1/src/v8natives.js
File src/v8natives.js (right):
https://codereview.chromium.org/856303002/diff/1/src/v8natives.js#newcode659
src/v8natives.js:659: // Assert: obj is not null or undefined
Remove?
https://codereview.chromium.org/856303002/diff/1/src/v8natives.js#newcode661
src/v8natives.js:661: if (IS_NULL_OR_UNDEFINED(func)) return;
return UNDEFINED;
for clarity?
https://codereview.chromium.org/856303002/diff/1/src/v8natives.js#newcode663
src/v8natives.js:663: throw MakeTypeError('called_non_callable', [typeof
func]);
maybe update this to use the new better error message than typeof?
https://codereview.chromium.org/856303002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
