LGTM with nits
https://codereview.chromium.org/856303002/diff/60001/test/mjsunit/harmony/array-from.js
File test/mjsunit/harmony/array-from.js (right):
https://codereview.chromium.org/856303002/diff/60001/test/mjsunit/harmony/array-from.js#newcode114
test/mjsunit/harmony/array-from.js:114: var arr = [1,2,3];
ws after ,
https://codereview.chromium.org/856303002/diff/60001/test/mjsunit/harmony/array-from.js#newcode119
test/mjsunit/harmony/array-from.js:119: if (!called) {
Maybe use assertFalse instead?
https://codereview.chromium.org/856303002/diff/60001/test/mjsunit/harmony/array-from.js#newcode139
test/mjsunit/harmony/array-from.js:139:
assertArrayLikeEquals(Array.from.call(thisArg, obj), [1,2,3],
constructor);
ws
https://codereview.chromium.org/856303002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
