Status: New
Owner: ----
New issue 3843 by [email protected]: AdjustAmountOfExternalAllocatedMemory
doesn't do update when it decides to GC
https://code.google.com/p/v8/issues/detail?id=3843
Steps to reproduce:
isolate->AdjustAmountOfExternalAllocatedMemory(1000000000);
Then call isolate->AdjustAmountOfExternalAllocatedMemory(0) and check that
the return value has been increased by 1000000000. Currently it just
returns whatever it was before.
This is because the code that updates the usage field is in an else-clause
that only runs if it didn't decide to do a GC.
int64_t amount = *amount_of_external_allocated_memory + change_in_bytes;
if (change_in_bytes > 0 &&
amount - *amount_of_external_allocated_memory_at_last_global_gc >
I::kExternalAllocationLimit) {
CollectAllGarbage("external memory allocation limit reached.");
} else {
*amount_of_external_allocated_memory = amount;
}
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
