https://codereview.chromium.org/881623002/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/881623002/diff/1/src/parser.cc#newcode1340
src/parser.cc:1340: Module* module = ParseModuleUrl(CHECK_OK);
This is fine for now but this should not return a Module AST node.
https://codereview.chromium.org/881623002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/881623002/diff/1/test/cctest/test-parsing.cc#newcode4722
test/cctest/test-parsing.cc:4722: CHECK(!parser.Parse());
Would it not be cleaner if we added ParseScript and ParseModule?
https://codereview.chromium.org/881623002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
