https://codereview.chromium.org/881623002/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/881623002/diff/1/src/parser.cc#newcode1273
src/parser.cc:1273: Module* Parser::ParseModuleVariable(bool* ok) {
On 2015/01/27 20:00:56, rossberg wrote:
Is this still used?
No, it's not. I thought it might be useful for "import *" but it's
simple enough to re-add later.
I'll delete this for now, but note that I'm not yet deleting stuff from
ast.h.
https://codereview.chromium.org/881623002/diff/1/src/parser.cc#newcode1347
src/parser.cc:1347: // TODO(ES6): Add a let declaration for each name
On 2015/01/27 20:00:55, rossberg wrote:
Nit: misleading comment, as imports cannot be let-declarations; they
are a new
form of declaration with a binding semantics completely different from
anything
that exists in the language or implementation so far.
Fair enough, s/let/appropriate/
https://codereview.chromium.org/881623002/diff/1/src/parser.cc#newcode2311
src/parser.cc:2311: // Also detect attempts at 'let' declarations in
sloppy mode.
On 2015/01/27 20:00:56, rossberg wrote:
Nit: remove the "also"
Done.
https://codereview.chromium.org/881623002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
